[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure |
Date: |
Fri, 13 Jan 2023 11:21:52 -0500 |
This function cannot fail since g_malloc0 aborts on OOM.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
audio/audio.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index d849a94a81..7b4b957945 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1712,7 +1712,6 @@ static AudioState *audio_init(Audiodev *dev, const char
*name)
size_t i;
int done = 0;
const char *drvname = NULL;
- VMChangeStateEntry *e;
AudioState *s;
struct audio_driver *driver;
/* silence gcc warning about uninitialized variable */
@@ -1830,11 +1829,7 @@ static AudioState *audio_init(Audiodev *dev, const char
*name)
s->period_ticks = dev->timer_period * (int64_t)SCALE_US;
}
- e = qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s);
- if (!e) {
- dolog ("warning: Could not register change state handler\n"
- "(Audio can continue looping even after stopping the VM)\n");
- }
+ qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s);
QTAILQ_INSERT_TAIL(&audio_states, s, list);
QLIST_INIT (&s->card_head);
--
2.38.1
- [PATCH 0/9] audio: remove deprecated QEMU_AUDIO env support, Daniel P . Berrangé, 2023/01/13
- [PATCH 4/9] audio: remove QEMUSoundCard linked list, Daniel P . Berrangé, 2023/01/13
- [PATCH 9/9] audio: remove support for QEMU_AUDIO_ env variables, Daniel P . Berrangé, 2023/01/13
- [PATCH 2/9] audio: remove special audio_calloc function, Daniel P . Berrangé, 2023/01/13
- [PATCH 6/9] docs: split the deprecation warning for soundcards vs VNC, Daniel P . Berrangé, 2023/01/13
- [PATCH 5/9] audio: remove empty AUD_remove_card method, Daniel P . Berrangé, 2023/01/13
- [PATCH 7/9] ui/vnc: don't accept VNC_ENCODING_AUDIO without audiodev, Daniel P . Berrangé, 2023/01/13
- [PATCH 3/9] audio: remove unused 'name' in QEMUSoundCard struct, Daniel P . Berrangé, 2023/01/13
- [PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure,
Daniel P . Berrangé <=
- [PATCH 8/9] audio: audio state is now mandatory for capture, Daniel P . Berrangé, 2023/01/13