[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: completion timeouts with pin-based interrupts in QEMU hw/nvme
From: |
Keith Busch |
Subject: |
Re: completion timeouts with pin-based interrupts in QEMU hw/nvme |
Date: |
Fri, 13 Jan 2023 09:52:46 -0700 |
On Fri, Jan 13, 2023 at 12:32:29PM +0000, Peter Maydell wrote:
> On Fri, 13 Jan 2023 at 08:55, Klaus Jensen <its@irrelevant.dk> wrote:
> >
> > +CC qemu pci maintainers
> >
> > Michael, Marcel,
> >
> > Do you have any comments on this thread? As you can see one solution is
> > to simply deassert prior to asserting, the other is to reintroduce a
> > pci_irq_pulse(). Both seem to solve the issue.
>
> Both seem to be missing any analysis of "this is what is
> happening, this is where we differ from hardware, this
> is why this is the correct fix". We shouldn't put in
> random "this seems to happen to cause the guest to boot"
> fixes, please.
It looks like these are being treated as edge instead of level
interrupts so the work-around is to create more edges. I would
definitely prefer a real fix, whether that's in the kernel or CPU
emulation or somewhere else, but I'm not sure I'll have time to see it
to completion.
FWIW, x86 seems to handle legacy IRQs with NVMe as expected. It's
actually easy enough for the DEASSERT to take so long that kernel
reports the irq as "spurious" because it's spinning too often on the
level.
Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Klaus Jensen, 2023/01/13
Re: completion timeouts with pin-based interrupts in QEMU hw/nvme,
Keith Busch <=
Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Klaus Jensen, 2023/01/16
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Keith Busch, 2023/01/16
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Guenter Roeck, 2023/01/17
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Peter Maydell, 2023/01/17
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Guenter Roeck, 2023/01/17
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Peter Maydell, 2023/01/18
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Keith Busch, 2023/01/18
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Keith Busch, 2023/01/18
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Alistair Francis, 2023/01/18
- Re: completion timeouts with pin-based interrupts in QEMU hw/nvme, Keith Busch, 2023/01/18