qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [for-8.0 v2 02/11] cryptodev: Remove 'name' & 'model' fields


From: Daniel P . Berrangé
Subject: Re: [for-8.0 v2 02/11] cryptodev: Remove 'name' & 'model' fields
Date: Mon, 16 Jan 2023 11:05:24 +0000
User-agent: Mutt/2.2.9 (2022-11-12)

On Tue, Nov 22, 2022 at 10:07:47PM +0800, zhenwei pi wrote:
> We have already used qapi to generate crypto device types, this allows
> to convert type to a string 'model', so the 'model' field is not
> needed.
> 
> And the 'name' field is not used by any backend driver, drop it.
> 
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
>  backends/cryptodev-builtin.c    |  3 +--
>  backends/cryptodev-lkcf.c       |  2 +-
>  backends/cryptodev-vhost-user.c |  3 +--
>  backends/cryptodev.c            | 11 +----------
>  include/sysemu/cryptodev.h      | 12 +++---------
>  5 files changed, 7 insertions(+), 24 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]