Re: Re: [for-8.0 v2 00/11] Refactor cryptodev

[Daniel P . Berrangé]

On Mon, Jan 16, 2023 at 05:53:07PM +0800, zhenwei pi wrote:
> On 12/20/22 23:36, Michael S. Tsirkin wrote:
> > On Tue, Nov 22, 2022 at 10:07:45PM +0800, zhenwei pi wrote:
> > > v1 -> v2:
> > > - fix coding style and use 'g_strjoin()' instead of 'char services[128]'
> > >    (suggested by Dr. David Alan Gilbert)
> > > - wrapper function 'cryptodev_backend_account' to record statistics, and
> > >    allocate sym_stat/asym_stat in cryptodev base class. see patch:
> > >    'cryptodev: Support statistics'.
> > > - add more arguments into struct CryptoDevBackendOpInfo, then
> > >    cryptodev_backend_crypto_operation() uses *op_info only.
> > > - support cryptodev QoS settings(BPS&OPS), both QEMU command line and QMP
> > >    command works fine.
> > > - add myself as the maintainer for cryptodev.
> > > 
> > > v1:
> > > - introduce cryptodev.json to describe the attributes of crypto device, 
> > > then
> > >    drop duplicated type declare, remove some virtio related dependence.
> > > - add statistics: OPS and bandwidth.
> > > - add QMP command: query-cryptodev
> > > - add HMP info command: cryptodev
> > > - misc fix: detect akcipher capability instead of exposing akcipher 
> > > service
> > >    unconditionally.
> > 
> > 
> > Can we get ACK on QAPI things please?
> > Thanks!
> > 
> 
> Hi Michael
> 
> I pinged QAPI maintainers, but I got no ACK.
> Could you please have a glance at this?

I am /not/ a  QAPI maintainer, but I've given some review of the patches
that touch QAPI.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|