qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] hw/acpi: Add missing includes


From: Markus Armbruster
Subject: Re: [PATCH 1/7] hw/acpi: Add missing includes
Date: Mon, 16 Jan 2023 14:02:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Bernhard Beschow <shentey@gmail.com> writes:

> Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster <armbru@redhat.com>:
>>Bernhard Beschow <shentey@gmail.com> writes:
>>
>>> When removing the "hw/boards.h" include from
>>> hw/acpi/acpi_dev_interface.h, these include directives must be added to make
>>> the code compile again.
>>>
>>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>>
>>You don't actually remove #include "hw/boards.h" from
>>hw/acpi/acpi_dev_interface.h in this series.  Accident?
>
> It gets removed in "[PATCH 3/7] hw/acpi/acpi_dev_interface: Resolve 
> AcpiDeviceIfClass::madt_cpu", no?

Got eaten on the way to me, and I didn't notice, because git-am is still
happy.  Sorry for the noise!

The commit message could point to PATCH 3.  However, I'd reshuffle a bit
instead.  Split PATCH 3 into everything but the removal of #include
"hw/boards.h", and the removal.  Squash PATCH 1 into the latter,
resulting in a straighforward cleanup patch.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]