Re: [PATCH v3 3/8] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)

[Peter Xu]

On Mon, Jan 16, 2023 at 11:35:22AM +0100, David Hildenbrand wrote:
> What about the following:
> 
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 7bc0cd9de9..cc910cab0f 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -188,6 +188,11 @@ struct VMStateDescription {
>       * One SaveStateEntry should either have the save_setup() specified or
>       * the vmsd with early_setup set to true. It should never have both
>       * things set.
> +     *
> +     * Note that for now, a SaveStateEntry cannot have a VMSD and
> +     * operations (e.g., save_setup()) set at the same time. For this reason,

This slightly duplicates with above?

> +     * also early_setup VMSDs are migrated in a QEMU_VM_SECTION_FULL section,
> +     * while save_setup() data is migrated in a QEMU_VM_SECTION_START 
> section.
>       */

This looks good.

Thanks,

-- 
Peter Xu