Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping

[Laurent Vivier]

Le 11/01/2023 à 09:50, Philippe Mathieu-Daudé a écrit :
> Series fully reviewed.
>
> Since v2:
> - Use array of const pointers to const (Richard)
>
> Since v1:
> - Fixed overwritten RECEIVING_BIT7 entry (Richard)
> - Picked R-b tags
>
> - Remove unused dummy MemoryRegion
> - Convert DPRINTF() to using trace events
>
> (series used as base for follow-up, better if merged via ARM tree)

I can take this via trivial, what do you prefer?

Laurent

> Philippe Mathieu-Daudé (5):
>    hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header
>    hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion
>    hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state()
>      helper
>    hw/i2c/bitbang_i2c: Trace state changes
>    hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events
>
>   hw/arm/musicpal.c            |  3 +-
>   hw/i2c/bitbang_i2c.c         | 80 ++++++++++++++++++++++--------------
>   hw/i2c/trace-events          |  7 ++++
>   include/hw/i2c/bitbang_i2c.h |  2 +
>   4 files changed, 61 insertions(+), 31 deletions(-)