qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 08/51] xen-platform: allow its creation with XEN_EMULATE m


From: David Woodhouse
Subject: Re: [PATCH v6 08/51] xen-platform: allow its creation with XEN_EMULATE mode
Date: Mon, 16 Jan 2023 17:56:41 +0000
User-agent: Evolution 3.44.4-0ubuntu1

On Mon, 2023-01-16 at 16:20 +0000, Paul Durrant wrote:
> > +    case 0: /* Platform flags */
> > +        if (xen_mode == XEN_EMULATE) {
> > +            /* XX: Use i440gx/q35 PAM setup to do this? */
> >                s->flags = val & PFFLAG_ROM_LOCK;
> 
> Given that this is not RFC, do you have a definite plan? TBH I think 
> only ancient (Bochs) ROMBIOS messes with this; I can't find any trace in 
> SeaBIOS anyway. So maybe we just don't care.

Indeed, I just don't think we care. If using the pam_config was easy
I'd have done it but it just isn't worth bothering with. So I'll leave
the note for anyone who comes later and finds a reason to care, but I
think it's fine.

Attachment: smime.p7s
Description: S/MIME cryptographic signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]