Re: [PATCH v6 09/51] i386/xen: handle guest hypercalls

[David Woodhouse]

On Mon, 2023-01-16 at 16:24 +0000, Paul Durrant wrote:
> > +    trace_kvm_xen_hypercall(CPU(cpu)->cpu_index, exit->u.hcall.cpl,
> > +                            exit->u.hcall.input, exit->u.hcall.params[0],
> > +                            exit->u.hcall.params[1], 
> > exit->u.hcall.params[2],
> > +                            exit->u.hcall.result);
> 
> It seems odd to have the trace message after the hypercall is handled. 
> Any additional tracing in the handler if going to come out before we're 
> told what hypercall it is.

Well yeah, but if we do it sooner then we don't have the result, and
end up with two separate trace lines to print the result too.

smime.p7s
Description: S/MIME cryptographic signature