Re: [PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets

[Laurent Vivier]

Hi Gerd,

If this patch is correct I can queue it via trivial branch.

Thanks,
Laurent

Le 02/12/2022 à 16:12, Pierre-Yves Ritschard a écrit :
> Hi,
>
> The provided patch allows the VNC websocket server of a qemu process to
> be provided over AF_UNIX as it is already possible for standard TCP VNC
> servers.
>
> Now that many clients support websocket connections, some exclusively,
> it can be useful to expose the VNC server. One such case is when a
> proxy is present on a host machine, allowing it to proxy to a
> deterministic location withouth having to keep track of port mappings.
>
> Removing the condition as is done in the provided patch creates a
> functional server. If there's a downside to this approach I could not
> figure it out while reading the code. My hunch was that the condition
> was there for a reason, but it did not jump at me.
>
> Cheers,
>    - pyr
>
> ---
>   ui/vnc.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git ui/vnc.c ui/vnc.c
> index 88f55cbf3c..b01a655400 100644
> --- ui/vnc.c
> +++ ui/vnc.c
> @@ -3729,11 +3729,6 @@ static int vnc_display_get_address(const char *addrstr,
>           addr->type = SOCKET_ADDRESS_TYPE_UNIX;
>           addr->u.q_unix.path = g_strdup(addrstr + 5);
>   
> -        if (websocket) {
> -            error_setg(errp, "UNIX sockets not supported with websock");
> -            goto cleanup;
> -        }
> -
>           if (to) {
>               error_setg(errp, "Port range not support with UNIX socket");
>               goto cleanup;