Re: [PATCH v5] tests/qtest: netdev: test stream and dgram backends

[Laurent Vivier]

On 1/17/23 11:00, Thomas Huth wrote:
> On 16/01/2023 09.40, Thomas Huth wrote:
> > On 16/01/2023 09.29, Laurent Vivier wrote:
> > > ping
> > >
> > > On 1/5/23 10:37, Laurent Vivier wrote:
> > > > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> > > > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > > > ---
> > > >
> > > > Notes:
> > > >      v5:
> > > >        - disable test_stream_fd and  test_dgram_fd on windows as socketpair()
> > > >          is not defined.
> > > >        - enable test_stream_unix_abstract only on linux as "abstract"
> > > >          unix socket parameter is only defined on linux.
> > > >      v4:
> > > >        - rework EXPECT_STATE()
> > > >        - use g_dir_make_tmp()
> > > >      v3:
> > > >      - Add "-M none" to avoid error:
> > > >        "No machine specified, and there is no default"
> > > >      v2:
> > > >      - Fix ipv6 free port allocation
> > > >      - Check for IPv4, IPv6, AF_UNIX
> > > >      - Use g_mkdtemp() rather than g_file_open_tmp()
> > > >      - Use socketpair() in test_stream_fd()
> > > >      v1: compared to v14 of "qapi: net: add unix socket type support to netdev 
> > > > backend":
> > > >      - use IP addresses 127.0.0.1 and ::1 rather than localhost
> > > >
> > > >   tests/qtest/meson.build     |   2 +
> > > >   tests/qtest/netdev-socket.c | 444 ++++++++++++++++++++++++++++++++++++
> > > >   2 files changed, 446 insertions(+)
> > > >   create mode 100644 tests/qtest/netdev-socket.c
> >
> > Acked-by: Thomas Huth <thuth@redhat.com>
> >
> > I'll queue it for my next pull request (unless someone else wants to take this 
> > first)
>
> Sorry, but I have to unqueue it again. I'm still seeing failures
> in the Windows Cirrus-CI:
>
>   https://cirrus-ci.com/task/5867407370092544
>
> For example:
>
> 218/556 qemu:qtest+qtest-aarch64 / qtest-aarch64/netdev-socket                    
> ERROR           0.02s   exit status 3
> ------------------------------------- 8< -------------------------------------
> stderr:
> socket_check_protocol_support() failed
>
> (C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests/qtest/netdev-socket.exe:3300):
>  GLib-CRITICAL **: 09:08:00.984: g_utf8_to_utf16: assertion 'str != NULL' failed
>
> (test program exited with status code 3)
>
> No clue where this comes from, though, I don't see a call
> to g_utf8_to_utf16() in your code?

OK, there is an error in the log:

socket_check_protocol_support() failed

So tmpdir is NULL and we try an g_rmdir(tmpdir)

I think this is the problem.

But why socket_check_protocol_support() fails?

test-char, test-io-channel-socket, test-util-sockets and test-yank also use it.

It seems we need to call socket_init() before...

I update my test.

Thanks,
Laurent