[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] ui/vnc.c: Allow websocket connections over AF_UNIX sockets |
|
Date: |
Tue, 17 Jan 2023 12:53:09 +0000 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Tue, Jan 17, 2023 at 01:43:12PM +0100, Gerd Hoffmann wrote:
> On Mon, Jan 16, 2023 at 07:15:08PM +0100, Laurent Vivier wrote:
> > Hi Gerd,
> >
> > If this patch is correct I can queue it via trivial branch.
>
> proxying tcp websocket connections to a unix socket looks like
> a reasonable use case to me.
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Please don't queue, this patch is not correct becasue it is failing
to validate the 'websocket' parameter at all.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|