qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).


From: John Berberian, Jr
Subject: Re: [PATCH v2] Fix exec migration on Windows (w32+w64).
Date: Tue, 17 Jan 2023 12:07:42 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

Apologies for the late response, I was traveling most of yesterday.

On 1/16/23 4:22 AM, Daniel P. Berrangé wrote:
When we introduce a new QAPI format for migration args though, I've
suggested we drop support for passing exec via shell, and require an
explicit argv[] array:

   https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg01434.html

For Windows since we don't have back compat to worry about, we
can avoid passing via cmd.exe from the start.

I think we should keep the behavior the same on all platforms. If such a change is to occur, it should happen at the same time on Windows and Unix-like systems. Platform-dependent ifdefs should be used to overcome platform-specific differences (e.g. the location of the shell), rather than give one platform entirely different functionality - otherwise we introduce needless confusion when someone accustomed to Linux tries to use an exec migration on Windows and it doesn't work the same way at all.

Best regards,
John Berberian, Jr.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]