Re: [PATCH v2 21/22] tcg/riscv: Introduce OPC_NOP

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/riscv/tcg-target.c.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc
> index 136fe54d4b..82ca86431e 100644
> --- a/tcg/riscv/tcg-target.c.inc
> +++ b/tcg/riscv/tcg-target.c.inc
> @@ -267,6 +267,7 @@ typedef enum {
>  #endif
>  
>      OPC_FENCE = 0x0000000f,
> +    OPC_NOP   = OPC_ADDI,   /* nop = addi r0,r0,0 */
>  } RISCVInsn;
>  
>  /*
> @@ -403,7 +404,7 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count)
>  {
>      int i;
>      for (i = 0; i < count; ++i) {
> -        p[i] = encode_i(OPC_ADDI, TCG_REG_ZERO, TCG_REG_ZERO, 0);
> +        p[i] = OPC_NOP;

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro