Re: [RFC PATCH v3 10/28] target/arm: move helpers to tcg/

[Fabiano Rosas]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 13/1/23 15:04, Fabiano Rosas wrote:
>> From: Claudio Fontana <cfontana@suse.de>
>> 
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>
>> ---
>>   target/arm/meson.build               | 16 ++--------------
>>   target/arm/tcg-stubs.c               | 23 +++++++++++++++++++++++
>>   target/arm/{ => tcg}/crypto_helper.c |  0
>>   target/arm/{ => tcg}/debug_helper.c  |  0
>>   target/arm/{ => tcg}/helper-a64.c    |  0
>>   target/arm/{ => tcg}/iwmmxt_helper.c |  0
>>   target/arm/{ => tcg}/m_helper.c      |  0
>>   target/arm/tcg/meson.build           | 14 ++++++++++++++
>>   target/arm/{ => tcg}/mte_helper.c    |  0
>>   target/arm/{ => tcg}/mve_helper.c    |  0
>>   target/arm/{ => tcg}/neon_helper.c   |  0
>>   target/arm/{ => tcg}/op_helper.c     |  0
>>   target/arm/{ => tcg}/pauth_helper.c  |  0
>>   target/arm/{ => tcg}/sme_helper.c    |  0
>>   target/arm/{ => tcg}/sve_helper.c    |  0
>>   target/arm/{ => tcg}/tlb_helper.c    |  0
>>   target/arm/{ => tcg}/vec_helper.c    |  0
>>   target/arm/{ => tcg}/vec_internal.h  |  0
>>   18 files changed, 39 insertions(+), 14 deletions(-)
>>   create mode 100644 target/arm/tcg-stubs.c
>>   rename target/arm/{ => tcg}/crypto_helper.c (100%)
>>   rename target/arm/{ => tcg}/debug_helper.c (100%)
>>   rename target/arm/{ => tcg}/helper-a64.c (100%)
>>   rename target/arm/{ => tcg}/iwmmxt_helper.c (100%)
>>   rename target/arm/{ => tcg}/m_helper.c (100%)
>>   rename target/arm/{ => tcg}/mte_helper.c (100%)
>>   rename target/arm/{ => tcg}/mve_helper.c (100%)
>>   rename target/arm/{ => tcg}/neon_helper.c (100%)
>>   rename target/arm/{ => tcg}/op_helper.c (100%)
>>   rename target/arm/{ => tcg}/pauth_helper.c (100%)
>>   rename target/arm/{ => tcg}/sme_helper.c (100%)
>>   rename target/arm/{ => tcg}/sve_helper.c (100%)
>>   rename target/arm/{ => tcg}/tlb_helper.c (100%)
>>   rename target/arm/{ => tcg}/vec_helper.c (100%)
>>   rename target/arm/{ => tcg}/vec_internal.h (100%)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> +void raise_exception_ra(CPUARMState *env, uint32_t excp, uint32_t syndrome,
>> +                        uint32_t target_el, uintptr_t ra)
>> +{
>> +    g_assert_not_reached();
>> +}
>
> Do you have a plan to restrict the calls to raise_exception_ra() to TCG?

Not yet, looks like moving the sdiv and udiv helpers which call
handle_possible_div0_trap would be enough.