Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

[Richard Henderson]

On 1/17/23 08:42, Philippe Mathieu-Daudé wrote:
> Remove dead code:
> - unused fields in CPUTriCoreState
> - (unexisting) tricore_def_t structure
> - forward declaration of tricore_boot_info structure
>    (declared in "hw/tricore/tricore.h", used once in
>     hw/tricore/tricore_testboard.c).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Given this compiles,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

It did surprise me though, since I would have expected something to use hflags.  It turns 
out the only thing that uses TRICORE_HFLAG_* is the kernel vs user-mode bits.

Bastian, there is code missing from cpu_get_tb_cpu_state, to copy env->PSW[11:10] to 
*flags.  At present it would seem that all code effectively runs in kernel mode.


r~