Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

[Michael S. Tsirkin]

On Mon, Jan 16, 2023 at 11:18:19AM +0000, Daniel P. Berrangé wrote:
> > +    for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) {
> 
> QEMU coding style doesn't declare types inside the for() control
> conditions. I'd suggest 'size_t i', and put it at top of this
> function.

It's actually kind of vague:

        Mixed declarations (interleaving statements and declarations within
        blocks) are generally not allowed; declarations should be at the 
beginning
        of blocks.

for loop starts a block, does it not?

It's in C99 but we use designated initializers widely so we already
depend on that.

-- 
MST