Re: [PATCH 1/3] avocado_qemu: enhance CANCEL message in QemuBaseTest:setUp()

[Fabiano Rosas]

Daniel Henrique Barboza <dbarboza@ventanamicro.com> writes:

> Trying to run 'make check-avocado' while having only non-x86_64 QEMU
> binaries built, in a x86_64 host machine, will give us the following
> cancel message:
>
> "CANCEL: No QEMU binary defined or found in the build tree"
>
> Which is not quite what's happening here. Avocado defaults to the host
> arch for every arch-agnostic test, and in the case mentioned above it
> cancelled the test because there were no qemu-system-x86_64 binary to be
> found.
>
> Change pick_default_qemu_bin() to return a (qemu_bin, arch) tuple, then
> use 'arch' in the CANCEL message. This will make the error more
> informative:
>
> "CANCEL: No QEMU binary defined or found in the build tree for arch x86_64"
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>