Re: [PATCH v7 38/51] i386/xen: add monitor commands to test event injection

[David Woodhouse]

On Tue, 2023-01-17 at 11:08 +0100, Markus Armbruster wrote:
> 
> > +# Since: x.xx
> 
> "Since: 8.0.0" (with any luck).  More of the same below.

Speaking of which... I guess this first series probably wants to be
considered as KVM and merged via Paolo? Or at least as far as #27/51
'i386/xen: Add support for Xen event channel delivery to vCPU' which is
coincidentally where Paul has got to with his reviews (thanks!).

After that it's less KVM intricacies, and more about the actual Xen
emulation. Perhaps we can mark hw/i386/kvm/xen*.[ch] as being covered
by the Xen maintainers? Or if Stefano and Anthony prefer, we can keep
it separate and mark it as maintained by Paul and myself?

What other reviews should be required for that? I'd certainly
appreciate hearing an opinion from mst and Marcel as PC machine
maintainers on the GSI parts — especially the gsi_handler() hook in
https://git.infradead.org/users/dwmw2/qemu.git/commitdiff/42526211d
("hw/xen: Support GSI mapping to PIRQ").

For reference, leaving out the newly-added files in hw/i386/kvm/xen*
and the imported Xen headers, this is the diffstat (of just phase 1,
not the RFC bits posted on top):

 accel/kvm/kvm-all.c                                |    2 +
 accel/xen/xen-all.c                                |    2 +
 docs/system/i386/xen.rst                           |   50 +
 docs/system/target-i386.rst                        |    1 +
 hmp-commands.hx                                    |   29 +
 hw/Kconfig                                         |    1 +
 hw/i386/Kconfig                                    |    5 +
 hw/i386/pc.c                                       |   26 +
 hw/i386/xen/meson.build                            |    5 +-
 hw/i386/xen/xen_platform.c                         |   57 +-
 hw/xen/Kconfig                                     |    3 +
 include/hw/i386/pc.h                               |    3 +
 include/hw/xen/xen.h                               |   21 +-
 include/monitor/hmp.h                              |    2 +
 include/sysemu/kvm_int.h                           |    3 +
 include/sysemu/kvm_xen.h                           |   40 +
 meson.build                                        |    1 +
 qapi/misc-target.json                              |  116 ++
 softmmu/globals.c                                  |    2 +-
 target/i386/cpu.c                                  |    1 +
 target/i386/cpu.h                                  |   19 +
 target/i386/kvm/kvm.c                              |  206 ++-
 target/i386/kvm/meson.build                        |    2 +
 target/i386/kvm/trace-events                       |    6 +
 target/i386/kvm/xen-compat.h                       |   51 +
 target/i386/kvm/xen-emu.c                          | 1711 ++++++++++++++++++++
 target/i386/kvm/xen-emu.h                          |   33 +
 target/i386/machine.c                              |   25 +

smime.p7s
Description: S/MIME cryptographic signature