Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

[Daniel P . Berrangé]

On Thu, Jan 19, 2023 at 12:01:18PM +0100, Philippe Mathieu-Daudé wrote:
> On 5/12/22 08:51, Marc-André Lureau wrote:
> > On Fri, Dec 2, 2022 at 1:51 PM Philippe Mathieu-Daudé <philmd@linaro.org> 
> > wrote:
> > > 
> > > The vnc-display-test is failing on Darwin:
> > > 
> > > tests/qtest/vnc-display-test:45038): ERROR **: 10:42:35.488: vnc-error:
> > > Unsupported auth type 17973672
> > 
> > It is supposed to pass. Can you share more details? It doesn't look
> > like an endianness issue, at first sight..
> 
> Adding '-trace vnc*' and setting _VNC_DEBUG in "vnc.h" I get:
> 
> # Start of vnc-display tests
> vnc_server_dpy_recreate VNC server dpy recreate dpy=0x130008000 size=640x480
> fmt=537004168
> Initializing VNC server with no auth
> vnc_auth_init VNC auth init state=0x130008000 websock=0 auth=1 subauth=0
> Initializing VNC server with no auth
> vnc_auth_init VNC auth init state=0x130008000 websock=1 auth=1 subauth=0
> vnc_client_connect VNC client connect state=0x130050000 ioc=0x13f7077f0
> Client sioc=0x13f7077f0 ws=0 auth=1 subauth=0
> New client on socket 0x13f7077f0
> vnc_set_share_mode/0x13f7077f0: undefined -> connecting
> Write Plain: Pending output 0x14880a400 size 4096 offset 12. Wait SSF 0
> Wrote wire 0x14880a400 12 -> 12
> Read plain 0x0 size 0 offset 0
> Read wire 0x13f8c8c00 4096 -> 12
> Client request protocol version 3.8
> Write Plain: Pending output 0x14880a400 size 4096 offset 2. Wait SSF 0
> Wrote wire 0x14880a400 2 -> 2
> Bail out! FATAL-ERROR: vnc-error: Unsupported auth type 5489072

^^^^ This specific message is comnig from the gtk-vnc client rather
than QEMU

Still doesn't tell us if the flaw is server or client side. The
logs from QEMU are insufficient. In theory it should be reporting
auth type == 0 though, for 'no auth' configs. 

> Read plain 0x13f8c8c00 size 4096 offset 0
> Read wire 0x13f8c8c00 4096 -> 1
> vnc_auth_reject VNC client auth rejected state=0x130050000 method expected=1
> got=176
> Write Plain: Pending output 0x14880a400 size 4096 offset 30. Wait SSF 0
> Wrote wire 0x14880a400 30 -> 30
> Closing down client sock: protocol error
> vnc_client_disconnect_start VNC client disconnect start state=0x130050000
> ioc=0x13f7077f0
> vnc_set_share_mode/0x13f7077f0: connecting -> disconnected
> vnc_client_disconnect_finish VNC client disconnect finish state=0x130050000
> ioc=0x13f7077f0
> 
> ** (tests/qtest/vnc-display-test:8465): ERROR **: 11:59:18.613: vnc-error:
> Unsupported auth type 5489072
> Trace/BPT trap: 5
> 
> Does that help? What else can I do to gather more info?

Modify vnc-display-test.c to call  vnc_util_set_debug(TRUE);
before vnc_connection_new(), to get the gtk-vnc debug logs
to stderr too.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|