[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1 |
Date: |
Thu, 19 Jan 2023 13:22:32 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 |
On 19/1/23 08:41, Philippe Mathieu-Daudé wrote:
On 18/1/23 20:34, Fabiano Rosas wrote:
These are the already reviewed patches from the first half of my
previous series:
20230113140419.4013-1-farosas@suse.de">https://lore.kernel.org/r/20230113140419.4013-1-farosas@suse.de
This unbreaks the --disable-tcg build, but there are issues in runtime
that are still being hashed out in the other series.
For the build _with_ TCG, this should behave the same as master.
Testing on Darwin:
17/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test
qemu-system-aarch64: unknown type 'arm-gicv3'
Reproducers:
$ ./qemu-system-aarch64 -display none -machine sbsa-ref -accel qtest
qemu-system-aarch64: unknown type 'arm-gicv3'
Abort trap: 6
frame #2: 0x00000001958522c8 libsystem_c.dylib`abort + 180
frame #3: 0x00000001003d32e8
qemu-system-aarch64`qdev_new(name="arm-gicv3") at qdev.c:164:9
frame #4: 0x00000001002f30d4 qemu-system-aarch64`sbsa_ref_init
[inlined] create_gic(sms=0x0000000103ff0d10) at sbsa-ref.c:405:16
frame #5: 0x00000001002f30a0
qemu-system-aarch64`sbsa_ref_init(machine=0x0000000103ff0d10) at
sbsa-ref.c:773:5
frame #6: 0x00000001000905c0
qemu-system-aarch64`machine_run_board_init(machine=0x0000000103ff0d10,
mem_path=<unavailable>, errp=<unavailable>) at machine.c:1404:5
For this one, I *think* the sbsa-ref create_gic() should follow
what the virt machine does to select the gic, generalizing Alex's
changes from
https://lore.kernel.org/qemu-devel/20221223090107.98888-1-agraf@csgraf.de/
Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1, Philippe Mathieu-Daudé, 2023/01/19