Re: [PATCH] tcg: Mark tcg helpers noinline to avoid an issue with LTO

[Philippe Mathieu-Daudé]

On 19/1/23 17:50, Richard Henderson wrote:
> Marking helpers __attribute__((noinline)) prevents an issue
> with GCC's ipa-split pass under --enable-lto.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1454
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> Idan, please give this a try.  By inspection, it fixes the issue
> with s390x's helper_divs32 function.
>
>
> r~
>
> ---
>   include/exec/helper-proto.h | 32 ++++++++++++++++++++++++--------
>   1 file changed, 24 insertions(+), 8 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>