[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 16/18] tests/tcg: Use SIGKILL for timeout
From: |
Alex Bennée |
Subject: |
[PATCH 16/18] tests/tcg: Use SIGKILL for timeout |
Date: |
Thu, 19 Jan 2023 18:04:17 +0000 |
From: Richard Henderson <richard.henderson@linaro.org>
linux-user blocks all signals while attempting to handle guest
signals (e.g. ABRT), which means that the default TERM sent by timeout
has no effect -- KILL instead.
When a guest aborts (possible nios2 guest bug), sending SIGABRT to
itself, I have caught one thread waiting in start_exclusive, and all
of the others blocked in exclusive_idle. I look at that and think
there's a bug in our start_exclusive locking, but I can't prove it.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230117035701.168514-2-richard.henderson@linaro.org>
[AJB: expanded commit message from cover letter]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/tcg/Makefile.target | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index 14bc013181..a3b0aaf8af 100644
--- a/tests/tcg/Makefile.target
+++ b/tests/tcg/Makefile.target
@@ -54,10 +54,10 @@ cc-option = if $(call cc-test, $1); then \
# $1 = test name, $2 = cmd, $3 = desc
ifeq ($(filter %-softmmu, $(TARGET)),)
-run-test = $(call quiet-command, timeout --foreground $(TIMEOUT) $2 > $1.out, \
+run-test = $(call quiet-command, timeout -s KILL --foreground $(TIMEOUT) $2 >
$1.out, \
TEST,$(or $3, $*, $<) on $(TARGET_NAME))
else
-run-test = $(call quiet-command, timeout --foreground $(TIMEOUT) $2, \
+run-test = $(call quiet-command, timeout -s KILL --foreground $(TIMEOUT) $2, \
TEST,$(or $3, $*, $<) on $(TARGET_NAME))
endif
--
2.34.1
- Re: [PATCH 14/18] tests/docker: drop debian-tricore-cross's partial status, (continued)
- [PATCH 15/18] tests/tcg: skip the vma-pthread test on CI, Alex Bennée, 2023/01/19
- [PATCH 16/18] tests/tcg: Use SIGKILL for timeout,
Alex Bennée <=
- [PATCH 18/18] MAINTAINERS: Fix the entry for tests/tcg/nios2, Alex Bennée, 2023/01/19
- [PATCH 17/18] gitlab: wrap up test results for custom runners, Alex Bennée, 2023/01/19
- [PATCH 11/18] lcitool: drop perl from QEMU project/dependencies, Alex Bennée, 2023/01/19