Re: [PATCH v2 00/10] tcg/loongarch64: Reorg goto_tb and cleanups

[WANG Xuerui]

Hi,

On 1/18/23 09:11, Richard Henderson wrote:
> Based-on: 20230117231051.354444-1-richard.henderson@linaro.org
> ("[PULL 00/22] tcg patch queue")
>
> Includes:
>    * Disassembler from target/loongarch/.
>    * Improvements to movi by Rui Wang, with minor tweaks.
>    * Improvements to setcond.
>    * Implement movcond.
>    * Fix the same goto_tb bug that affected some others.
>
>
> r~
>
>
> Richard Henderson (9):
>    target/loongarch: Enable the disassembler for host tcg
>    target/loongarch: Disassemble jirl properly
>    target/loongarch: Disassemble pcadd* addresses
>    tcg/loongarch64: Update tcg-insn-defs.c.inc
>    tcg/loongarch64: Introduce tcg_out_addi
>    tcg/loongarch64: Improve setcond expansion
>    tcg/loongarch64: Implement movcond
>    tcg/loongarch64: Use tcg_pcrel_diff in tcg_out_ldst
>    tcg/loongarch64: Reorg goto_tb implementation
>
> Rui Wang (1):
>    tcg/loongarch64: Optimize immediate loading
>
>   tcg/loongarch64/tcg-target-con-set.h          |   5 +-
>   tcg/loongarch64/tcg-target-con-str.h          |   2 +-
>   tcg/loongarch64/tcg-target.h                  |  11 +-
>   disas.c                                       |   2 +
>   target/loongarch/disas.c                      |  39 +-
>   .../loongarch/insn_trans/trans_branch.c.inc   |   2 +-
>   target/loongarch/insns.decode                 |   3 +-
>   target/loongarch/meson.build                  |   3 +-
>   tcg/loongarch64/tcg-insn-defs.c.inc           |  10 +-
>   tcg/loongarch64/tcg-target.c.inc              | 364 ++++++++++++------
>   10 files changed, 300 insertions(+), 141 deletions(-)
>   mode change 100644 => 100755 tcg/loongarch64/tcg-insn-defs.c.inc
Sorry for the late review; I was focusing more on LLVM and day job these 
days. I've reviewed some of these and will take a look at the rest (and 
test all of them on native HW) tonight. Thanks very much for all the 
refactoring!