Re: [RFC v2 2/2] spice: Add an option to forward the dmabuf directly to the encoder (v2)

[Gerd Hoffmann]

  Hi,

> The other option I can think of is to just not deal with drawables at all and 
> somehow
> directly share the dmabuf fd with the Encoder.

This is what I expected to happen.  This also the case when using
dma-bufs for local display.

> > IMHO we should not hard-code todays spice-server capabilities like this.
> > For starters this isn't true for spice-server versions which don't (yet)
> > have your patches.  Also the capability might depend on hardware
> > support.  IMHO we need some feature negotiation between qemu and spice
> > here.
> [Kasireddy, Vivek] Ok, I can get rid of this chunk in v3. However, given the 
> numerous
> features supported by the Spice server, I suspect implementing feature 
> negotiation
> might get really challenging. Is there any other way around this that you can 
> think of?

I'm thinking about a simple bool, i.e. replace the current hard failure
for the remote case with a query whenever the server supports dma-buf
video encoding or not.

take care,
  Gerd