[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/32] hmp: Drop redundant argument check from add_completion_opt
From: |
Markus Armbruster |
Subject: |
[PATCH 05/32] hmp: Drop redundant argument check from add_completion_option() |
Date: |
Tue, 24 Jan 2023 13:19:19 +0100 |
No need to check for null arguments, no caller passes them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor/misc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/monitor/misc.c b/monitor/misc.c
index c18a713d9c..d58a81c452 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -1353,9 +1353,6 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const
char *name)
static void add_completion_option(ReadLineState *rs, const char *str,
const char *option)
{
- if (!str || !option) {
- return;
- }
if (!strncmp(option, str, strlen(str))) {
readline_add_completion(rs, option);
}
--
2.39.0
- Re: [PATCH 01/32] monitor: Drop unnecessary includes, (continued)
- [PATCH 03/32] char: Move HMP commands from monitor/ to chardev/, Markus Armbruster, 2023/01/24
- [PATCH 02/32] audio: Move HMP commands from monitor/ to audio/, Markus Armbruster, 2023/01/24
- [PATCH 11/32] qom: Move HMP commands from monitor/ to qom/, Markus Armbruster, 2023/01/24
- [PATCH 06/32] readline: Extract readline_add_completion_of() from monitor, Markus Armbruster, 2023/01/24
- [PATCH 14/32] hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma(), Markus Armbruster, 2023/01/24
- [PATCH 08/32] trace: Move HMP commands from monitor/ to trace/, Markus Armbruster, 2023/01/24
- [PATCH 05/32] hmp: Drop redundant argument check from add_completion_option(),
Markus Armbruster <=
- [PATCH 13/32] rocker: Move HMP commands from monitor to hw/net/rocker/, Markus Armbruster, 2023/01/24
- [PATCH 15/32] net: Move HMP commands from monitor to net/, Markus Armbruster, 2023/01/24
- [PATCH 27/32] monitor: Move monitor_putc() next to monitor_puts & external linkage, Markus Armbruster, 2023/01/24
- [PATCH 32/32] monitor: Rename misc.c to hmp-target.c, Markus Armbruster, 2023/01/24
- [PATCH 09/32] machine: Move QMP commands from monitor/ to hw/core/, Markus Armbruster, 2023/01/24
- [PATCH 12/32] block: Factor out hmp_change_medium(), and move to block/monitor/, Markus Armbruster, 2023/01/24
- [PATCH 22/32] stats: Move QMP commands from monitor/ to stats/, Markus Armbruster, 2023/01/24
- [PATCH 31/32] monitor: Loosen coupling between misc.c and monitor.c slightly, Markus Armbruster, 2023/01/24