[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [QEMU][PATCH v4 05/10] include/hw/xen/xen_common: return error from
From: |
Stefano Stabellini |
Subject: |
Re: [QEMU][PATCH v4 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server |
Date: |
Wed, 25 Jan 2023 13:58:43 -0800 (PST) |
User-agent: |
Alpine 2.22 (DEB 394 2020-01-19) |
On Wed, 25 Jan 2023, Vikram Garhwal wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
>
> This is done to prepare for enabling xenpv support for ARM architecture.
> On ARM it is possible to have a functioning xenpv machine with only the
> PV backends and no IOREQ server. If the IOREQ server creation fails,
> continue to the PV backends initialization.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
I know I am co-author of the patch but just for record-keeping to
remember that I also reviewed this patch:
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> include/hw/xen/xen_common.h | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
> index 9a13a756ae..9ec69582b3 100644
> --- a/include/hw/xen/xen_common.h
> +++ b/include/hw/xen/xen_common.h
> @@ -467,9 +467,10 @@ static inline void xen_unmap_pcidev(domid_t dom,
> {
> }
>
> -static inline void xen_create_ioreq_server(domid_t dom,
> - ioservid_t *ioservid)
> +static inline int xen_create_ioreq_server(domid_t dom,
> + ioservid_t *ioservid)
> {
> + return 0;
> }
>
> static inline void xen_destroy_ioreq_server(domid_t dom,
> @@ -600,8 +601,8 @@ static inline void xen_unmap_pcidev(domid_t dom,
> PCI_FUNC(pci_dev->devfn));
> }
>
> -static inline void xen_create_ioreq_server(domid_t dom,
> - ioservid_t *ioservid)
> +static inline int xen_create_ioreq_server(domid_t dom,
> + ioservid_t *ioservid)
> {
> int rc = xendevicemodel_create_ioreq_server(xen_dmod, dom,
> HVM_IOREQSRV_BUFIOREQ_ATOMIC,
> @@ -609,12 +610,14 @@ static inline void xen_create_ioreq_server(domid_t dom,
>
> if (rc == 0) {
> trace_xen_ioreq_server_create(*ioservid);
> - return;
> + return rc;
> }
>
> *ioservid = 0;
> use_default_ioreq_server = true;
> trace_xen_default_ioreq_server();
> +
> + return rc;
> }
>
> static inline void xen_destroy_ioreq_server(domid_t dom,
> --
> 2.17.0
>
>
- [QEMU][PATCH v4 00/10] Introduce xenpvh machine for arm architecture, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 02/10] hw/i386/xen: rearrange xen_hvm_init_pc, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server, Vikram Garhwal, 2023/01/25
- Re: [QEMU][PATCH v4 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server,
Stefano Stabellini <=
- [QEMU][PATCH v4 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 07/10] hw/xen/xen-hvm-common: Use g_new and error_setg_errno, Vikram Garhwal, 2023/01/25
- [QEMU][PATCH v4 09/10] hw/arm: introduce xenpvh machine, Vikram Garhwal, 2023/01/25