[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/3] block/rbd: Add support for layered encryption
From: |
Ilya Dryomov |
Subject: |
Re: [PATCH v5 0/3] block/rbd: Add support for layered encryption |
Date: |
Fri, 27 Jan 2023 10:30:12 +0100 |
On Sun, Jan 15, 2023 at 1:40 PM Or Ozeri <oro@il.ibm.com> wrote:
>
> v5: nit fixes
> v4: split to multiple commits
> add support for more than just luks-any in layered encryption
> nit fixes
> v3: further nit fixes suggested by @idryomov
> v2: nit fixes suggested by @idryomov
>
> Or Ozeri (3):
> block/rbd: Remove redundant stack variable passphrase_len
> block/rbd: Add luks-any encryption opening option
> block/rbd: Add support for layered encryption
>
> block/rbd.c | 189 ++++++++++++++++++++++++++++++++++++++++---
> qapi/block-core.json | 31 ++++++-
> 2 files changed, 206 insertions(+), 14 deletions(-)
>
> --
> 2.25.1
>
>
Hi Or,
Looks good, just a couple of really minor nits which can be ignored if
you don't end up reposting.
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Thanks,
Ilya