[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] migration: report migration thread name to libvirt
From: |
Juan Quintela |
Subject: |
Re: [PATCH 1/3] migration: report migration thread name to libvirt |
Date: |
Mon, 30 Jan 2023 05:19:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Jiang Jiacheng <jiangjiacheng@huawei.com> wrote:
> Report migration thread name to libvirt in order to
> support query migration thread infomation by its name.
>
> Signed-off-by: Jiang Jiacheng <jiangjiacheng@huawei.com>
> ---
> migration/migration.c | 3 +++
> migration/multifd.c | 5 ++++-
> qapi/migration.json | 12 ++++++++++++
> 3 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 52b5d39244..b4ce458bb9 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3955,6 +3955,9 @@ static void *migration_thread(void *opaque)
> MigThrError thr_error;
> bool urgent = false;
>
> + /* report migration thread name to libvirt */
> + qapi_event_send_migration_name("live_migration");
> +
> rcu_register_thread();
>
> object_ref(OBJECT(s));
I am not sure about this.
This is not an event, in my point of view.
What is the problem adding it to info migrate or similar?
Looks more logical to me.
Later, Juan.