Re: [PATCH v4 2/3] accel/tcg: Add debuginfo support

[Ilya Leoshkevich]

On Mon, 2023-01-30 at 15:33 +0100, Thomas Huth wrote:
> On 12/01/2023 16.20, Ilya Leoshkevich wrote:
> > Add libdw-based functions for loading and querying debuginfo. Load
> > debuginfo from the system and the linux-user loaders.
> > 
> > This is useful for the upcoming perf support, which can then put
> > human-readable guest symbols instead of raw guest PCs into perfmap
> > and
> > jitdump files.
> > 
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > ---
> ...
> > diff --git a/meson.build b/meson.build
> > index 175517eafde..cab8c67d961 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1648,6 +1648,12 @@ if libbpf.found() and not cc.links('''
> >     endif
> >   endif
> >   
> > +# libdw
> > +libdw = dependency('libdw',
> > +                   method: 'pkg-config',
> > +                   kwargs: static_kwargs,
> > +                   required: false)
> > +
> 
>   Hi,
> 
> I recently did a build with "configure --without-default-features"
> and I 
> noticed that this new libdw does not get disabled automatically
> there, which 
> looks kind of weird. Is there a reason that there is no config knob
> here to 
> disable it like we have it with all the other optional libraries that
> we 
> support?
> 
>   Thomas

Hi,

this sounds like an omission on my part - I'll have a look at this.

Best regards,
Ilya