[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/56] virtio-rng-pci: fix migration compat for vectors
From: |
Michael S. Tsirkin |
Subject: |
[PULL 08/56] virtio-rng-pci: fix migration compat for vectors |
Date: |
Mon, 30 Jan 2023 15:19:07 -0500 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Fixup the migration compatibility for existing machine types
so that they do not enable msi-x.
Symptom:
(qemu) qemu: get_pci_config_device: Bad config data: i=0x34 read: 84 device: 98
cmask: ff wmask: 0 w1cmask:0
qemu: Failed to load PCIDevice:config
qemu: Failed to load virtio-rng:virtio
qemu: error while loading state for instance 0x0 of device
'0000:00:03.0/virtio-rng'
qemu: load of migration failed: Invalid argument
Note: This fix will break migration from 7.2->7.2-fixed with this patch
bz: https://bugzilla.redhat.com/show_bug.cgi?id=2155749
Fixes: 9ea02e8f1 ("virtio-rng-pci: Allow setting nvectors, so we can use MSI-X")
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20230109105809.163975-1-dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: David Daney <david.daney@fungible.com>
Fixes: 9ea02e8f1 ("virtio-rng-pci: Allow setting nvectors, so we can use
MSI-X")<br>
Signed-off-by: Dr. David Alan Gilbert <<a href="mailto:dgilbert@redhat.com"
target="_blank">dgilbert@redhat.com</a>><br>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/core/machine.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 616f3a207c..f7761baab5 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -46,6 +46,7 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
GlobalProperty hw_compat_7_1[] = {
{ "virtio-device", "queue_reset", "false" },
+ { "virtio-rng-pci", "vectors", "0" },
};
const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
--
MST
- [PULL 00/56] virtio,pc,pci: features, cleanups, fixes, Michael S. Tsirkin, 2023/01/30
- [PULL 02/56] hw/i386/acpi-build: Remove unused attributes, Michael S. Tsirkin, 2023/01/30
- [PULL 03/56] hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml(), Michael S. Tsirkin, 2023/01/30
- [PULL 05/56] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu, Michael S. Tsirkin, 2023/01/30
- [PULL 04/56] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h", Michael S. Tsirkin, 2023/01/30
- [PULL 06/56] vhost-user: Correct a reference of TARGET_AARCH64, Michael S. Tsirkin, 2023/01/30
- [PULL 07/56] hw/pci-host: Use register definitions from PCI standard, Michael S. Tsirkin, 2023/01/30
- [PULL 08/56] virtio-rng-pci: fix migration compat for vectors,
Michael S. Tsirkin <=
- [PULL 09/56] intel-iommu: Document iova_tree, Michael S. Tsirkin, 2023/01/30
- [PULL 10/56] x86: don't let decompressed kernel image clobber setup_data, Michael S. Tsirkin, 2023/01/30
- [PULL 13/56] tests: acpi: whitelist DSDT blobs for tests that use pci-bridges, Michael S. Tsirkin, 2023/01/30
- [PULL 12/56] tests: acpi: cleanup arguments to make them more readable, Michael S. Tsirkin, 2023/01/30
- [PULL 14/56] tests: acpi: extend pcihp with nested bridges, Michael S. Tsirkin, 2023/01/30