Re: [PATCH 4/6] gitlab-ci.d/buildtest: Merge the --without-default-* jobs

[Thomas Huth]

On 30/01/2023 14.28, Fabiano Rosas wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
> > Let's safe some CI minutes by merging these two jobs. We can now
> > also drop "--disable-capstone" since the capstone submodule has
> > been removed a while ago. We should rather tes --disable-fdt now
> > to test a compilation without the "dtc" submodule (for this we
> > have to drop i386-softmmu from the target list unfortunately).
> > Additionally, the qtests with s390x and sh4 are not read for
> > "--without-default-devices" yet,
>
> Fyi, I've been working on a series to make the qtests work with the
> --without-default-devices build for i386 or aarch64.

Great, I'm looking forward to this!

> There are some qtests explicitly adding devices without checking and
> hardcoded defaults on vl.c and machine init code without a matching
> KConfig dependency.

Yes, I also noticed this while working on these patches ... many other 
binaries even don't start since they try to instantiate a default NIC that 
might not be available ... fixing the whole of QEMU will certainly take some 
time, but if you get x86 and aarch64 working, that's certainly a good start!

> > so we can only test mips64 and
> > avr here now.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>

Thanks!

 Thomas