qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/2] audio: make audiodev introspectable by management app


From: Thomas Huth
Subject: Re: [PATCH v2 0/2] audio: make audiodev introspectable by management apps
Date: Tue, 31 Jan 2023 11:09:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 23/01/2023 09.39, Thomas Huth wrote:
Here's a respin from Daniel's audiodev introspection patches from
2021. I've rebased them to the current master branch and addressed
the review comments from v1.

The Audiodev QAPI type is not introspectable via query-qmp-schema as
nothing in QMP uses it. "-audiodev" is not introspectable via
query-command-line-options because it avoided legacy QemuOpts.

To fix it, introduce a tiny "query-audiodev" QMP command that uses
the "Audiodev" QAPI structure, so that it shows up in the schema.
Then mark the various backend types with conditionals so that only
the ones that were available at compile time show up in the schema.

Daniel P. Berrangé (2):
   qapi, audio: add query-audiodev command
   qapi, audio: Make introspection reflect build configuration more
     closely

Since there were no objections and since Gerd seems to be pretty busy with other stuff recently, I'll dare to pick these up for my next pull request.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]