[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/27] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()
From: |
Thomas Huth |
Subject: |
[PULL 09/27] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap() |
Date: |
Tue, 31 Jan 2023 11:11:47 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Use the compiler built-in function to byte swap values,
as the compiler is clever and will fold constants.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230111163147.71761-2-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/qemu/bswap.h | 31 ++++++-------------------------
1 file changed, 6 insertions(+), 25 deletions(-)
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index 346d05f2aa..ca2b4c3f15 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -37,31 +37,12 @@ static inline uint64_t bswap64(uint64_t x)
#endif
#ifdef BSWAP_FROM_FALLBACKS
-static inline uint16_t bswap16(uint16_t x)
-{
- return (((x & 0x00ff) << 8) |
- ((x & 0xff00) >> 8));
-}
-
-static inline uint32_t bswap32(uint32_t x)
-{
- return (((x & 0x000000ffU) << 24) |
- ((x & 0x0000ff00U) << 8) |
- ((x & 0x00ff0000U) >> 8) |
- ((x & 0xff000000U) >> 24));
-}
-
-static inline uint64_t bswap64(uint64_t x)
-{
- return (((x & 0x00000000000000ffULL) << 56) |
- ((x & 0x000000000000ff00ULL) << 40) |
- ((x & 0x0000000000ff0000ULL) << 24) |
- ((x & 0x00000000ff000000ULL) << 8) |
- ((x & 0x000000ff00000000ULL) >> 8) |
- ((x & 0x0000ff0000000000ULL) >> 24) |
- ((x & 0x00ff000000000000ULL) >> 40) |
- ((x & 0xff00000000000000ULL) >> 56));
-}
+#undef bswap16
+#define bswap16(_x) __builtin_bswap16(_x)
+#undef bswap32
+#define bswap32(_x) __builtin_bswap32(_x)
+#undef bswap64
+#define bswap64(_x) __builtin_bswap64(_x)
#endif
#undef BSWAP_FROM_BYTESWAP
--
2.31.1
- [PULL 00/27] qtest and misc patches, Thomas Huth, 2023/01/31
- [PULL 01/27] tests/qtest: netdev: test stream and dgram backends, Thomas Huth, 2023/01/31
- [PULL 06/27] travis.yml: Use the libfdt from the distro instead of the submodule, Thomas Huth, 2023/01/31
- [PULL 09/27] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap(),
Thomas Huth <=
- [PULL 02/27] tests/qtest/qom-test: Stop spamming the test log, Thomas Huth, 2023/01/31
- [PULL 03/27] tests/qtest/bios-tables-test: Make the test less verbose by default, Thomas Huth, 2023/01/31
- [PULL 05/27] configs/targets/nios2-softmmu: Add TARGET_NEED_FDT=y to the nios2 config, Thomas Huth, 2023/01/31
- [PULL 15/27] MAINTAINERS: Abort HAXM maintenance, Thomas Huth, 2023/01/31
- [PULL 13/27] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD, Thomas Huth, 2023/01/31
- [PULL 17/27] tests/tcg: Do not build/run TCG tests if TCG is disabled, Thomas Huth, 2023/01/31
- [PULL 08/27] tests/docker/dockerfiles: Add libfdt to the i386 and to the riscv64 container, Thomas Huth, 2023/01/31
- [PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin, Thomas Huth, 2023/01/31
- [PULL 11/27] qemu/bswap: Remove <byteswap.h> dependency, Thomas Huth, 2023/01/31
- [PULL 14/27] qemu/bswap: Use compiler __builtin_bswap() on NetBSD, Thomas Huth, 2023/01/31