Re: [PATCH 0/3] VIA PM Improvements

[BALATON Zoltan]

On Sun, 29 Jan 2023, Bernhard Beschow wrote:
> This series is part of my work to bring the VIA south bridges to the PC machine
> [1]. First it resolves a fixme in the device model by using the dedicated ACPI
> interrupt register for SCI routing. It then enables the device model to switch
> to ACPI. Finally, ACPI shutdown is implemented which guests can take advantage
> of after switching to ACPI mode.
>
> Testing done:
> - `make check`
> - `qemu-system-ppc -M pegasos2 \
>                   -rtc base=localtime \
>                   -device ati-vga,guest_hwcursor=true,romfile="" \
>                   -cdrom morphos-3.17.iso \
>                   -kernel morphos-3.17/boot.img`
> - `qemu-system-ppc -M pegasos2 \
>                   -device ati-vga,romfile="" \
>                   -cdrom morphos-3.17.iso \
>                   -bios pegasos2.rom`

I can't review this in detail so I can only give some cosmetic comments, 
do with it what you like. For testing I think shutdown from MorphOS worked 
with the pegasos2.rom after this patch:

https://lists.nongnu.org/archive/html/qemu-devel/2021-11/msg01871.html

but that was not accepted as it was deemed to be an error in memory layer 
but then that wasn't fixed so probably this workaround is still needed to 
get it to work with big endian guest on little endian host. Does poweroff 
work from Linux?

Regards,
BALATON Zoltan

> - `qemu-system-x86_64 -M pc -m 2G -accel kvm -cpu host -cdrom
>   manjaro-kde-21.3.2-220704-linux515.iso` on my pc-via branch seems to work
>   without any noticable differences to piix3 except that hotplugging isn't
>   implemented.
>
> [1] https://github.com/shentok/qemu/tree/pc-via
>
> Bernhard Beschow (3):
>  hw/isa/vt82c686: Fix SCI routing
>  hw/isa/vt82c686: Allow PM controller to switch to ACPI mode
>  hw/isa/vt82c686: Implement ACPI powerdown
>
> hw/isa/vt82c686.c | 75 +++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 62 insertions(+), 13 deletions(-)
>
> --
> 2.39.1