qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] readconfig-test: add test for accelerator configuration


From: Richard Henderson
Subject: Re: [PATCH 4/4] readconfig-test: add test for accelerator configuration
Date: Tue, 31 Jan 2023 05:20:37 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 1/31/23 05:18, Thomas Huth wrote:
On 17/01/2023 09.07, Paolo Bonzini wrote:
Test that invalid configurations do not cause a SIGSEGV, and cover a
valid configuration as well.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  tests/qtest/libqtest.c        | 28 +++++++++++++++++-----
  tests/qtest/libqtest.h        | 12 ++++++++++
  tests/qtest/readconfig-test.c | 45 ++++++++++++++++++++++++++++-------
  3 files changed, 70 insertions(+), 15 deletions(-)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 64ba98bc5853..53d766fe3fa5 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -402,6 +402,26 @@ static QTestState *G_GNUC_PRINTF(1, 0) qtest_spawn_qemu(const char *fmt, ...)
      return s;
  }
+QTestState *G_GNUC_PRINTF(1, 0) qtest_init_bare(const char *args)

I think you don't need the G_GNUC_PRINTF here, do you?

Indeed, it is incorrect.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]