qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 12/12] parallels: Incorrect condition in out-of-image chec


From: Denis V. Lunev
Subject: Re: [PATCH v9 12/12] parallels: Incorrect condition in out-of-image check
Date: Tue, 31 Jan 2023 16:37:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 1/31/23 11:27, Alexander Ivanov wrote:
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
  block/parallels.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/parallels.c b/block/parallels.c
index e4faa14add..e469fe3f78 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -455,7 +455,7 @@ static int parallels_check_outside_image(BlockDriverState 
*bs,
      high_off = 0;
      for (i = 0; i < s->bat_size; i++) {
          off = bat2sect(s, i) << BDRV_SECTOR_BITS;
-        if (off > size) {
+        if (off + s->cluster_size > size) {
              fprintf(stderr, "%s cluster %u is outside image\n",
                      fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
              res->corruptions++;
Reviewed-by: Denis V. Lunev <den@openvz.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]