Re: [PATCH 04/40] igb: Include the second VLAN tag in the buffer

[Philippe Mathieu-Daudé]

On 14/4/23 13:37, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   hw/net/igb_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
> index 55de212447..f725ab97ae 100644
> --- a/hw/net/igb_core.c
> +++ b/hw/net/igb_core.c
> @@ -1590,7 +1590,7 @@ static ssize_t
>   igb_receive_internal(IGBCore *core, const struct iovec *iov, int iovcnt,
>                        bool has_vnet, bool *external_tx)
>   {
> -    static const int maximum_ethernet_hdr_len = (ETH_HLEN + 4);
> +    static const int maximum_ethernet_hdr_len = (ETH_HLEN + 8);

Aren't VLAN tags 16-bit wide? Could you convert this magic value
to some verbose-but-obvious definitions?

Is it worth adding a vlan_tag_t typedef in include/net/eth.h?

>       uint16_t queues = 0;
>       uint32_t n = 0;