Re: [PATCH 20/21] Hexagon (target/hexagon) Move pkt_has_store_s1 to DisasContext

[Richard Henderson]

On 4/26/23 01:42, Taylor Simpson wrote:
> +static TCGv gen_slotval(DisasContext *ctx)
> +{
> +    TCGv slotval = tcg_temp_new();
> +    tcg_gen_movi_tl(slotval, ctx->pkt->pkt_has_store_s1 & 1);
> +    tcg_gen_ori_tl(slotval, slotval, ctx->insn->slot << 1);
> +    return slotval;
> +}

This can be entirely constant:

    int slotval = (ctx->pkt->pkt_has_store_s1 & 1)
                | (ctx->insn->slot << 1);
    return tcg_constant_tl(slotval);


Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~