[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/12] accel/tcg: Uncache the host address for instruction fetch w
|
From: |
Richard Henderson |
|
Subject: |
[PULL 02/12] accel/tcg: Uncache the host address for instruction fetch when tlb size < 1 |
|
Date: |
Tue, 2 May 2023 12:20:13 +0100 |
From: Weiwei Li <liweiwei@iscas.ac.cn>
When PMP entry overlap part of the page, we'll set the tlb_size to 1, which
will make the address in tlb entry set with TLB_INVALID_MASK, and the next
access will again go through tlb_fill.However, this way will not work in
tb_gen_code() => get_page_addr_code_hostp(): the TLB host address will be
cached, and the following instructions can use this host address directly
which may lead to the bypass of PMP related check.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1542.
Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230422130329.23555-6-liweiwei@iscas.ac.cn>
---
accel/tcg/cputlb.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index e984a98dc4..efa0cb67c9 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1696,6 +1696,11 @@ tb_page_addr_t get_page_addr_code_hostp(CPUArchState
*env, target_ulong addr,
if (p == NULL) {
return -1;
}
+
+ if (full->lg_page_size < TARGET_PAGE_BITS) {
+ return -1;
+ }
+
if (hostp) {
*hostp = p;
}
--
2.34.1
- [PULL 00/12] tcg patch queue, Richard Henderson, 2023/05/02
- [PULL 01/12] softmmu: Tidy dirtylimit_dirty_ring_full_time, Richard Henderson, 2023/05/02
- [PULL 03/12] qemu/bitops.h: Limit rotate amounts, Richard Henderson, 2023/05/02
- [PULL 02/12] accel/tcg: Uncache the host address for instruction fetch when tlb size < 1,
Richard Henderson <=
- [PULL 04/12] qemu/host-utils.h: Add clz and ctz functions for lower-bit integers, Richard Henderson, 2023/05/02
- [PULL 05/12] tcg: Add tcg_gen_gvec_andcs, Richard Henderson, 2023/05/02
- [PULL 07/12] qemu/int128: Re-shuffle Int128Alias members, Richard Henderson, 2023/05/02
- [PULL 06/12] tcg: Add tcg_gen_gvec_rotrs, Richard Henderson, 2023/05/02
- [PULL 09/12] accel/tcg: Add cpu_ld*_code_mmu, Richard Henderson, 2023/05/02
- [PULL 08/12] migration/xbzrle: Use __attribute__((target)) for avx512, Richard Henderson, 2023/05/02
- [PULL 11/12] tcg/mips: Conditionalize tcg_out_exts_i32_i64, Richard Henderson, 2023/05/02
- [PULL 10/12] tcg/loongarch64: Conditionalize tcg_out_exts_i32_i64, Richard Henderson, 2023/05/02
- [PULL 12/12] tcg: Introduce tcg_out_movext2, Richard Henderson, 2023/05/02