|
| From: | Juan Quintela |
| Subject: | Re: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API |
| Date: | Tue, 02 May 2023 20:24:05 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote: > colo_checkpoint_notify() is mostly used in colo.c. Outside we use it > once when x-checkpoint-delay migration parameter is set. So, let's > simplify the external API to only that function - notify COLO that > parameter was set. This make external API more robust and hides > implementation details from external callers. Also this helps us to > make COLO module optional in further patch (i.e. we are going to add > possibility not build the COLO module). > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Reviewed-by: Juan Quintela <quintela@redhat.com>
| [Prev in Thread] | Current Thread | [Next in Thread] |