[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 1/2] igb: RX descriptors handling cleanup
|
From: |
Sriram Yagnaraman |
|
Subject: |
RE: [PATCH v3 1/2] igb: RX descriptors handling cleanup |
|
Date: |
Wed, 3 May 2023 07:46:12 +0000 |
> -----Original Message-----
> From: Tomasz Dzieciol/VIM Integration (NC) /SRPOL/Engineer/Samsung
> Electronics <t.dzieciol@partner.samsung.com>
> Sent: Tuesday, 2 May 2023 16:01
> To: Sriram Yagnaraman <sriram.yagnaraman@est.tech>; qemu-
> devel@nongnu.org; akihiko.odaki@daynix.com
> Cc: jasowang@redhat.com; k.kwiecien@samsung.com;
> m.sochacki@samsung.com
> Subject: RE: [PATCH v3 1/2] igb: RX descriptors handling cleanup
>
> Not Linux/DPDK/FreeBSD for IGB.
>
> Change here adds additional condition (RXCSUM.IPPCSE set) to enable putting
> IP ID into descriptor, besides clearing RXCSUM.PCSD (required according to
> Intel 82576 datasheet) that was not present in the e1000e code.
>
Yes, we can't even use ethtool to set this field.
My suggestion is to not add/maintain code that we cannot test. I leave it up to
Akhikho to decide if we really need to implement IPPCSE.
The default value of RXCSUM.IPPCSE is unset, so we could as well ignore this
field until there is a user who sets this.
Anyhow, I will wait with futher comments, until you respin this after splitting
the changes as requested.