Re: [PATCH v2 10/10] xxhash: remove qemu_xxhash7

[Richard Henderson]

On 5/3/23 10:17, Alex Bennée wrote:
> Now we no longer have users for qemu_xxhash7 we can drop an additional
> multiply and rol and make qemu_xxhash6 the implementation. Adjust the
> smaller hash functions accordingly.
>
> Message-Id: <20230420150009.1675181-11-alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   include/qemu/xxhash.h | 17 ++++-------------
>   1 file changed, 4 insertions(+), 13 deletions(-)

Oh, well, I noticed during this review that we're not hashing cs_base, so probably 
expanding this to xxhash8 more proper.

cs_base is used for all kinds of important things, such as AArch64 flags expansion, so we 
might get better hashing performance by including it.


r~