From: Mads Ynddal <m.ynddal@samsung.com>
I wanted to use simpletrace.py for an internal project, so I tried to update
and polish the code. Some of the commits resolve specific issues, while some
are more subjective.
I've tried to divide it into commits so we can discuss the
individual changes, and I'm ready to pull things out, if it isn't needed.
Just a quick note to say that I'll be on and off the rest of this week, but this is on my radar to look at soon.
A question for you: do you think it's possible to move simpletrace into qemu/python/utils? This requires cleaning up the code to some fairly pedantic standards, but helps protect it against rot as we change target python versions.
No problem if that's too much to ask. just want to know if you had looked into it.
v2:
* Added myself as maintainer of simpletrace.py
* Improve docstring on `process`
* Changed call to `process` in scripts/analyse-locks-simpletrace.py to reflect new argument types
* Replaced `iteritems()` with `items()` in scripts/analyse-locks-simpletrace.py to support Python 3
Mads Ynddal (12):
simpletrace: Improve parsing of sys.argv; fix files never closed.
simpletrace: Annotate magic constants from QEMU code
simpletrace: changed naming of edict and idtoname to improve
readability
simpletrace: update code for Python 3.11
simpletrace: Changed Analyzer class to become context-manager
simpletrace: Simplify construction of tracing methods
simpletrace: Improved error handling on struct unpack
simpletrace: define exception and add handling
simpletrace: Refactor to separate responsibilities
MAINTAINERS: add maintainer of simpletrace.py
scripts/analyse-locks-simpletrace.py: changed iteritems() to items()
scripts/analyse-locks-simpletrace.py: reflect changes to process in
simpletrace.py
MAINTAINERS | 8 +-
scripts/analyse-locks-simpletrace.py | 5 +-
scripts/simpletrace.py | 307 ++++++++++++---------------
3 files changed, 150 insertions(+), 170 deletions(-)
--
2.38.1