Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

[Thomas Huth]

On 04/05/2023 09.10, Ani Sinha wrote:
> > On 04-May-2023, at 12:05 PM, Thomas Huth <thuth@redhat.com> wrote:
> >
> > On 03/05/2023 16.55, Ani Sinha wrote:
> > > mformat and xorriso tools are needed by biosbits avocado tests. This patchset
> > > adds those two tools in the docker container images.
> >
> > tests/qtest/cdrom-test.c already uses genisoimage to create ISO images, and the 
> > containers already have that tool installed. Could you maybe switch the 
> > biosbits test to use that tool? Or the other way round? ... at least having two 
> > tools to create ISO images in our containers sounds IMHO excessive.
>
> The dependency comes from the use of grub-mkrescue in the avocado test in order 
> to generate the iso with the bios bits enabled grub and boot off with it. 
> Grub-mkrescue is a bash script that uses mformat and xorriso.

Ok, then we could maybe try to convert the cdrom-test.c file to use xorriso 
instead?

 Thomas