Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

[Daniel P . Berrangé]

On Thu, May 04, 2023 at 01:52:36PM +0530, Ani Sinha wrote:
> 
> 
> > On 04-May-2023, at 1:32 PM, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > 
> > On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote:
> >> On 03/05/2023 16.55, Ani Sinha wrote:
> >>> mformat and xorriso tools are needed by biosbits avocado tests. This 
> >>> patchset
> >>> adds those two tools in the docker container images.
> >> 
> >> tests/qtest/cdrom-test.c already uses genisoimage to create ISO images, and
> >> the containers already have that tool installed. Could you maybe switch the
> >> biosbits test to use that tool? Or the other way round? ... at least having
> >> two tools to create ISO images in our containers sounds IMHO excessive.
> > 
> > It looks like this series wasn't tested,
> 
> Oh I wasn’t sure which tests I were to run to verify this because 
> https://www.qemu.org/docs/master/devel/testing.html does not mention any 
> specific tests to run after:
> 
>       • Once the merge request is accepted, go back to QEMU and update the 
> tests/lcitool/libvirt-ci submodule to point to a commit that contains the 
> mappings.yml update. Then add the prerequisite and run make lcitool-refresh.
> 
> Is it “make docker-all-tests” ? Maybe we can update the doc. This is the 
> first time me updating the docker images with new packages and I doing not 
> touch this infrastructure part at all.

By testing, I mean run the CI pipeline in GitLab to see if everything
still passes. I expect the alpine job will fail the container build.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|