qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0


From: Konstantin Kostiuk
Subject: Re: [PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601
Date: Thu, 4 May 2023 12:02:20 +0300

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Thu, May 4, 2023 at 11:19 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
On Thu, May 04, 2023 at 09:54:09AM +0200, Thomas Huth wrote:
> All current versions of glib require _WIN32_WINNT set to 0x0601
> or higher already, and we also use this value as a minimum in our
> osdep.h header file, so there is no way to still compile this code
> with an older version of the Windows ABI. Thus we can drop this
> check now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qga/commands-win32.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


reply via email to

[Prev in Thread] Current Thread [Next in Thread]