[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/6] qga: Fix suspend on Linux guests without systemd
|
From: |
Konstantin Kostiuk |
|
Subject: |
[PULL 6/6] qga: Fix suspend on Linux guests without systemd |
|
Date: |
Thu, 4 May 2023 12:56:57 +0300 |
From: Mark Somerville <mark@qpok.net>
Allow the Linux guest agent to attempt each of the suspend methods
(systemctl, pm-* and writing to /sys) in turn.
Prior to this guests without systemd failed to suspend due to
`guest_suspend` returning early regardless of the return value of
`systemd_supports_mode`.
Signed-off-by: Mark Somerville <mark@qpok.net>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
qga/commands-posix.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 97754930c1..def857d773 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1922,10 +1922,10 @@ static void guest_suspend(SuspendMode mode, Error
**errp)
if (systemd_supports_mode(mode, &local_err)) {
mode_supported = true;
systemd_suspend(mode, &local_err);
- }
- if (!local_err) {
- return;
+ if (!local_err) {
+ return;
+ }
}
error_free(local_err);
@@ -1934,10 +1934,10 @@ static void guest_suspend(SuspendMode mode, Error
**errp)
if (pmutils_supports_mode(mode, &local_err)) {
mode_supported = true;
pmutils_suspend(mode, &local_err);
- }
- if (!local_err) {
- return;
+ if (!local_err) {
+ return;
+ }
}
error_free(local_err);
--
2.25.1
- [PULL 0/6] Misc QGA patches, Konstantin Kostiuk, 2023/05/04
- [PULL 1/6] qga/linux: add usb support to guest-get-fsinfo, Konstantin Kostiuk, 2023/05/04
- [PULL 3/6] qga: Add `merged` variant to GuestExecCaptureOutputMode, Konstantin Kostiuk, 2023/05/04
- [PULL 2/6] qga: Refactor guest-exec capture-output to take enum, Konstantin Kostiuk, 2023/05/04
- [PULL 4/6] qga: test: Add tests for `merged` flag, Konstantin Kostiuk, 2023/05/04
- [PULL 5/6] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601, Konstantin Kostiuk, 2023/05/04
- [PULL 6/6] qga: Fix suspend on Linux guests without systemd,
Konstantin Kostiuk <=
- Re: [PULL 0/6] Misc QGA patches, Richard Henderson, 2023/05/04
- Re: [PULL 0/6] Misc QGA patches, Richard Henderson, 2023/05/05