Re: [PATCH 1/2] migration: Document all migration_stats

[David Edmondson]

Juan Quintela <quintela@redhat.com> writes:

> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 149af932d7..0e49c236fa 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -22,17 +22,60 @@
>   * one thread).
>   */
>  typedef struct {
> +    /*
> +     * number of bytes that were dirty last time that we sync with the

Minor, but given that you are writing sentences, please start with a
capital letter.

> +     * guest memory.  We use that to calculate the downtime.  As the
> +     * remaining dirty amounts to what we know that is still dirty
> +     * since last iteration, not counting what the guest has dirtied
> +     * sync we synchronize bitmaps.
> +     */
>      Stat64 dirty_bytes_last_sync;
> +    /*
> +     * number of pages dirtied by second.
> +     */
>      Stat64 dirty_pages_rate;
> +    /*
> +     * number of times we have synchronize guest bitmaps.
> +     */
>      Stat64 dirty_sync_count;
> +    /*
> +     * number of times zero copy failed to send any page using zero
> +     * copy.
> +     */
>      Stat64 dirty_sync_missed_zero_copy;
> +    /*
> +     * number of bytes sent at migration completion stage while the
> +     * guest is stopped.
> +     */
>      Stat64 downtime_bytes;
> +    /*
> +     * number of pages transferred that were full of zeros.
> +     */
>      Stat64 zero_pages;
> +    /*
> +     * number of bytes sent through multifd channels.
> +     */
>      Stat64 multifd_bytes;
> +    /*
> +     * number of pages transferred that were not full of zeros.
> +     */
>      Stat64 normal_pages;
> +    /*
> +     * number of bytes sent during postcopy.
> +     */
>      Stat64 postcopy_bytes;
> +    /*
> +     * number of postcopy page faults that we have handled during
> +     * postocpy stage.
> +     */
>      Stat64 postcopy_requests;
> +    /*
> +     *  number of bytes sent during precopy stage.

Spurious double space before 'number'.

> +     */
>      Stat64 precopy_bytes;
> +    /*
> +     * total number of bytes transferred.
> +     */
>      Stat64 transferred;
>  } MigrationAtomicStats;
>  
> -- 
> 2.40.0
-- 
I'm not the reason you're looking for redemption.