RE: [PATCH v4 00/10] COLO: improve build options

[Zhang, Chen]

> -----Original Message-----
> From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Sent: Saturday, April 29, 2023 3:49 AM
> To: qemu-devel@nongnu.org
> Cc: lukasstraub2@web.de; quintela@redhat.com; Zhang, Chen
> <chen.zhang@intel.com>; vsementsov@yandex-team.ru
> Subject: [PATCH v4 00/10] COLO: improve build options
> 
> v4:
> 01: add r-b by Lukas
> 02: new
> 03: - keep x-colo capability enum value unconditional
>     - drop ifdefs in options.c and keep capability check instead
>     - update stubs
>     - add missed a-b by Dr. David
> 04: keep filter-mirror untouched, add r-b by Juan
> 
> others: new. Some further improvements of COLO module API. May be
> merged separately.
> 
> Hi all!
> 
> COLO substem seems to be useless when CONFIG_REPLICATION is unset, as
> we simply don't allow to set x-colo capability in this case. So, let's not 
> compile
> in unreachable code and interface we cannot use when
> CONFIG_REPLICATION is unset.
> 
> Also, provide personal configure option for COLO Proxy subsystem.

This series looks good to me.
Please add the new configure option related comments to docs/COLO-FT.txt, 
block-replication.txt, colo-proxy.txt.

Thanks
Chen

> 
> Vladimir Sementsov-Ogievskiy (10):
>   block/meson.build: prefer positive condition for replication
>   colo: make colo_checkpoint_notify static and provide simpler API
>   build: move COLO under CONFIG_REPLICATION
>   configure: add --disable-colo-proxy option
>   migration: drop colo_incoming_thread from MigrationIncomingState
>   migration: process_incoming_migration_co: simplify code flow around
>     ret
>   migration: split migration_incoming_co
>   migration: process_incoming_migration_co(): move colo part to colo
>   migration: disallow change capabilities in COLO state
>   migration: block incoming colo when capability is disabled
> 
>  block/meson.build              |   2 +-
>  hmp-commands.hx                |   2 +
>  include/migration/colo.h       |  18 +++++-
>  meson_options.txt              |   2 +
>  migration/colo.c               | 100 +++++++++++++++++++--------------
>  migration/meson.build          |   6 +-
>  migration/migration-hmp-cmds.c |   2 +
>  migration/migration.c          |  51 +++++++----------
>  migration/migration.h          |  11 +++-
>  migration/options.c            |   6 +-
>  net/meson.build                |  13 ++++-
>  qapi/migration.json            |   9 ++-
>  scripts/meson-buildoptions.sh  |   3 +
>  stubs/colo-compare.c           |   7 +++
>  stubs/colo.c                   |  37 ++++++++++++
>  stubs/meson.build              |   2 +
>  16 files changed, 181 insertions(+), 90 deletions(-)  create mode 100644
> stubs/colo-compare.c  create mode 100644 stubs/colo.c
> 
> --
> 2.34.1